On Fri, Feb 8, 2019 at 10:29 AM Evgenii Seliavka <evg.selyavka@...> wrote:
As in CONTRIBUTING_SCRIPTS.md, we're after tools that do one thing and
do it well, so I'd generally avoid adding features that didn't belong
in tools. In this case, it might actually belong because you're
looking at what we could call "accept failures".
But I'm struggling to read your diff. Can you please regenerate with
-u, and also there's a lot of churn:
- event.task, event.ip,
- inet_ntop(AF_INET6, event.daddr).encode(),
- inet_ntop(AF_INET6, event.saddr).encode(),
+ fields = [event.pid,
+ inet_ntop(AF_INET6, event.daddr).encode(),
+ inet_ntop(AF_INET6, event.saddr).encode(),
Changing many things at once makes it harder to understand the change
you want us to look at.