Send iovisor-dev mailing list submissions to
        iovisor-dev@...

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.iovisor.org/mailman/listinfo/iovisor-dev
or, via email, send a message with subject or body 'help' to
        iovisor-dev-request@...

You can reach the person managing the list at
        iovisor-dev-owner@...

When replying, please edit your Subject line so it is more specific
than "Re: Contents of iovisor-dev digest..."


Today's Topics:

   1. Re: Error with printk and bpf_trace_printk
      (Jesper Dangaard Brouer)
   2. reminder: IO Visor TSC/Dev Meeting (Brenden Blanco)


----------------------------------------------------------------------

Message: 1
Date: Tue, 30 May 2017 14:24:37 +0200
From: Jesper Dangaard Brouer <brouer@...>
To: Adel Fuchs <adelfuchs@...>
Cc: "xdp-newbies@..." <xdp-newbies@...>,
        netdev@..., "iovisor-dev@..."
        <iovisor-dev@...>
Subject: Re: [iovisor-dev] Error with printk and bpf_trace_printk
Message-ID: <20170530142437.656ec63d@...>
Content-Type: text/plain; charset=US-ASCII


Notice, there are two mailing lists (Cc'ed) that you should likely ask
these kind of questions on (instead of netdev), depending on if this is
mostly related to bpf (iovisor-dev@...) or somehow
related to XDP (xdp-newbies@...).

See my answer inlined below:

On Sun, 28 May 2017 17:48:20 +0300 Adel Fuchs <adelfuchs@...> wrote:

> I have a working eBPF program, and I'm trying to add outputs to it.
> I'm not able to use both printk and bpf_trace_printk functions. I get
> this error:
>
> ELF contains non-map related relo data in entry 0 pointing to section
> 8! Compiler bug?!
>
> Prog section 'ingress' rejected: Invalid argument (22)!
>  - Type:         3
>  - Instructions: 16 (0 over limit)
>  - License:      GPL
>
> Verifier analysis:
>
> 0: (bf) r6 = r1
> 1: (18) r1 = 0x0
> 3: (85) call bpf_unspec#0
> unknown func bpf_unspec#0
>
> Error fetching program/map!
> Failed to retrieve (e)BPF data!
>
> Are there certain "includes" that I need to add?
> In addition, I'm not sure I'm using the function correctly. I just
> wrote: printk("hi")

You obviously cannot call printk directly from and eBPF program.
I wonder how you got this compiling...

As you hinted yourself, you should be using: bpf_trace_printk().
But it is actually tricky to use... and not much help is around to
figure this out.

First of all the output end-up in this file: /sys/kernel/debug/tracing/trace_pipe
Remember to read the output use 'cat' like:

 sudo cat /sys/kernel/debug/tracing/trace_pipe

And only the first process to read the output gets the output...


I deduct you are using the TC/iproute2 examples:
 https://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git/tree/examples/bpf

Next gotcha is that, you need to provide the char* string in a very
special way to make this compile correctly.  The iproute2 provide a
helper define called "printt()" in include/bpf_api.h for this:

#ifndef printt
# define printt(fmt, ...)                                               \
        ({                                                              \
                char ____fmt[] = fmt;                                   \
                trace_printk(____fmt, sizeof(____fmt), ##__VA_ARGS__);  \
        })
#endif

Or see my solution here:
[1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/samples/bpf/xdp_ddos01_blacklist_kern.c#L86:L99


Another gotcha I've experienced is that if you format the string
incorrectly, or use a modifier like %X, which bpf_trace_printk() does
not seem to understand, then you "hear-nothing"...  Also experienced if
using more than 3 arguments, then it fails or also go silent. Be
careful when using this somewhat "flaky" debug facility.

Do remember these bpf_trace_printk() should only be used for debugging,
as it is very slow...
--
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


------------------------------

Message: 2
Date: Tue, 30 May 2017 17:12:21 -0700
From: Brenden Blanco <bblanco@...>
To: iovisor-dev@...
Subject: [iovisor-dev] reminder: IO Visor TSC/Dev Meeting
Message-ID:
        <CAH9hs-+=AzXRsgkhCU+4R2K81QPUokaO=vJaEjxP=nvdLntjYg@...>
Content-Type: text/plain; charset="utf-8"

Please join us tomorrow for our bi-weekly call. As usual, this meeting is
open to everybody and completely optional.
You might be interested to join if:
You want to know what is going on in BPF land
You are doing something interesting yourself with BPF and would like to
share
You want to know what the heck BPF is

=== IO Visor Dev/TSC Meeting ===

Every 2 weeks on Wednesday, from Wednesday, January 25, 2017, to no end date
11:00 am  |  Pacific Daylight Time (San Francisco, GMT-07:00)  |  1 hr

https://bluejeans.com/568677804/

https://www.timeanddate.com/worldclock/meetingdetails.html?year=2017&month=5&day=31&hour=18&min=0&sec=0&p1=900
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.iovisor.org/pipermail/iovisor-dev/attachments/20170530/59c57dee/attachment-0001.html>

------------------------------

_______________________________________________
iovisor-dev mailing list
iovisor-dev@...
https://lists.iovisor.org/mailman/listinfo/iovisor-dev


End of iovisor-dev Digest, Vol 21, Issue 7
******************************************